Afternoon tea near the castle is surefire winner

Cannonball Restaurant and Bar on Castlehill, opposite Edinburgh Castle.